Enable configuration of hash algorithm

monix / shade

Memcached client for Scala

MIT License

106 stars 19 forks source link

Enable configuration of hash algorithm #37

Closed mspielberg closed 8 years ago

mspielberg commented 8 years ago

If using Shade to address a cluster of Memcache nodes shared with other clients, it's necessary to synchronize the algorithm mapping keys to nodes. The default spymemcached hash algorithm is based on Java's String.hashCode(), and generally not available on non-JVM platforms. This change allows the user to change the hash algorithm used to something with potentially more CPU overhead, but also more cross-platform availability.

coveralls commented 8 years ago

Coverage increased (+0.7%) to 83.983% when pulling b35bf7a4efd89e9d70566c9c9fad582bd3607a55 on mspielberg:master into 46ef64c8f4d02e1450c17101b9cbd7f601f3e04d on alexandru:master.

lloydmeta commented 8 years ago

Thanks, this LGTM :)

mspielberg commented 8 years ago

Any idea when this might be released? Issue #33 mentions a release in 2 months as of February, but April is come and gone.

lloydmeta commented 8 years ago

@mspielberg I think @alexandru will cut a new release as soon as he comes back from the conference he is currently at.

alexandru commented 8 years ago

Sorry for the delay guys. I've just released 1.7.3, it's synchronizing on Maven Central.

derjust commented 8 years ago

Late to the party but thank you so much @mspielberg. I was looking exactly for that feature and it just took me to update the build.sbt to get this working :)