search

monix / shade

Memcached client for Scala
MIT License
106 stars 19 forks source link

Feature/monix #43

Closed lloydmeta closed 7 years ago

lloydmeta commented 7 years ago

Closes #33

I think it's time to migrate to Monix. Adding 2.12.x support should probably come after this.

I think Monix is a path than using Sincron because it the Scheduler class.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 84.198% when pulling 1142d03006996fa67bc470d2194c08e4a1b06054 on lloydmeta:feature/monix into f4642b908552c8108c630723b75bdea1e13a9bd8 on alexandru:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 84.198% when pulling 0583db5aba73641afaac34dcd4617f770fea5e45 on lloydmeta:feature/monix into ffe1e590cc1f3db64824e302e1e1e155f2d19863 on alexandru:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 84.198% when pulling c37e12e840ba2f2888ea6daa4e7d147fc5bac642 on lloydmeta:feature/monix into ffe1e590cc1f3db64824e302e1e1e155f2d19863 on alexandru:master.

alexandru commented 7 years ago

Thanks @lloydmeta - for now this would do, but it would also be cool to also integrate Task and CancelableFuture, because those requests to Memcached (from what I remember) are cancelable.

Also, I'm thinking of making this project part of the Monix family so to speak, by moving it in the @monix organization. Would you agree to that?

Let me know your thoughts.

lloydmeta commented 7 years ago

Integrating Task and CancelableFuture sounds like a good idea. I think we would probably need/want to expose a new API for that ?

As for moving this project into the Monix family, that sounds good to me. Clearly Monix is gaining momentum so moving Shade into it might be a good idea so that we can get more exposure, users, and contributions. In any case, you're the owner so you're free to do with it how you like :)

alexandru commented 7 years ago

@lloydmeta the idea is that I don't want to be the only owner anymore, too much of a responsibility. I don't even want to be the only one capable of making releases anymore - for Shade I'll look into sharing with you that privilege, which probably involves using a new PGP Key for signing and seeing how to share the privileges for io.monix on Sonatype. We'll see.

I just moved it.