Open alexandru opened 7 years ago
:exclamation: No coverage uploaded for pull request base (
master@22c216b
). Click here to learn what that means. The diff coverage is34.96%
.
@@ Coverage Diff @@
## master #50 +/- ##
=========================================
Coverage ? 34.69%
=========================================
Files ? 8
Lines ? 392
Branches ? 48
=========================================
Hits ? 136
Misses ? 256
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
...src/main/scala/shade/memcached/Configuration.scala | 0% <ø> (ø) |
|
...mcached/src/main/scala/shade/memcached/Codec.scala | 0% <0%> (ø) |
|
.../src/main/scala/shade/memcached/SpyMemcached.scala | 0% <0%> (ø) |
|
...hed/src/main/scala/shade/memcached/Memcached.scala | 0% <0%> (ø) |
|
...ocal/jvm/src/main/scala/shade/local/Platform.scala | 0% <0%> (ø) |
|
...local/js/src/main/scala/shade/local/Platform.scala | 0% <0%> (ø) |
|
...ain/scala/shade/local/mutable/TimeBasedCache.scala | 61.22% <61.22%> (ø) |
|
...n/scala/shade/local/immutable/TimeBasedCache.scala | 92.68% <92.68%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 22c216b...3b5c1bb. Read the comment docs.
Just skimmed over and it looks promising :+1: I'll have a look over the weekend.
Any idea what kind of performance impact this has?
Changes in version 2:
addListener
, so we no longer have to use its dirty internals for exposing futures and tasksTask
, in addition to the methods exposingCancelableFuture
shade-local
andshade-memcached
, the idea being that Shade should be a project for "caching" and it should maybe provide other integrations meant for caching stuff (e.g. Redis?)For review, it might be easier to just review the files in the version2 branch.