monix / shade

Memcached client for Scala
MIT License
106 stars 19 forks source link

Work in Progress: Version 2 #50

Open alexandru opened 7 years ago

alexandru commented 7 years ago

Changes in version 2:

For review, it might be easier to just review the files in the version2 branch.

codecov[bot] commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@22c216b). Click here to learn what that means. The diff coverage is 34.96%.

@@            Coverage Diff            @@
##             master      #50   +/-   ##
=========================================
  Coverage          ?   34.69%           
=========================================
  Files             ?        8           
  Lines             ?      392           
  Branches          ?       48           
=========================================
  Hits              ?      136           
  Misses            ?      256           
  Partials          ?        0
Impacted Files Coverage Δ
...src/main/scala/shade/memcached/Configuration.scala 0% <ø> (ø)
...mcached/src/main/scala/shade/memcached/Codec.scala 0% <0%> (ø)
.../src/main/scala/shade/memcached/SpyMemcached.scala 0% <0%> (ø)
...hed/src/main/scala/shade/memcached/Memcached.scala 0% <0%> (ø)
...ocal/jvm/src/main/scala/shade/local/Platform.scala 0% <0%> (ø)
...local/js/src/main/scala/shade/local/Platform.scala 0% <0%> (ø)
...ain/scala/shade/local/mutable/TimeBasedCache.scala 61.22% <61.22%> (ø)
...n/scala/shade/local/immutable/TimeBasedCache.scala 92.68% <92.68%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22c216b...3b5c1bb. Read the comment docs.

lloydmeta commented 7 years ago

Just skimmed over and it looks promising :+1: I'll have a look over the weekend.

Any idea what kind of performance impact this has?