Scapy Extension Patch Submission

[GoogleCodeExporter]

This is not a bug, I've created a patch to support integration of killerbee 
into Scapy via an extension (tools/zbscapy) and a couple of other features.  
The patch is for an older version of killerbee. If this patch seems useful, I 
would not mind doing the work to merge it with the current version and resubmit 
it.

Thanks.

Original issue reported on code.google.com by zeroStei...@gmail.com on 3 Dec 2011 at 12:55

Attachments:

• killerbee_patch_showcase.png
• killerbee_sjm.patch

[GoogleCodeExporter]

Hi,
This patch looks great. I'm glad to see some use of the Scapy 802.15.4 layer I 
started, and especially merging it with KillerBee. I'd greatly appreciate this 
applied to the new version of KillerBee. A few questions:
- From a brief scan, this looks like it some tweaks may fix issue 8. Would you 
agree?
- Are any of these parts, such as ZigBee crypt that fit better in the Scapy 
extensions? I don't think so, based on a quick read, but just want to make sure.
- It seems like your 'def kbdev():' addition seems to have some improvements by 
listing capabilities of devices. My request would be to have the 
kbutils.devlist() function call return this information for all devices (not 
just RZUSBSTICKs), as an extra element in the tuple or something. Then zbid 
could be patched to display it, etc. Does that make sense? (Goal is to not 
break command line utilities, but allow them to take advantage of this extra 
info if desired.)

Please let me know if you have questions, or if I can be of help.

Original comment by rmspe...@gmail.com on 21 Feb 2012 at 12:00

• Changed state: Accepted
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

- From a brief scan, this looks like it some tweaks may fix issue 8. Would you 
agree?
-- From what I understand about the problem, yes.
- Are any of these parts, such as ZigBee crypt that fit better in the Scapy 
extensions? I don't think so, based on a quick read, but just want to make sure.
-- If I understand the question correctly, no because the ZigbeeCrypt code is a 
C extension that has to be compiled.
- It seems like your 'def kbdev():' addition seems to have some improvements by 
listing capabilities of devices. My request would be to have the 
kbutils.devlist() function call return this information for all devices (not 
just RZUSBSTICKs), as an extra element in the tuple or something. Then zbid 
could be patched to display it, etc. Does that make sense? (Goal is to not 
break command line utilities, but allow them to take advantage of this extra 
info if desired.)
-- I think that would be great, but I only know the information for the 
RZUSBSTICKs, would you like for me to add this as a separate patch?

Original comment by zeroStei...@gmail.com on 21 Feb 2012 at 2:05

[GoogleCodeExporter]

Thanks. I agree on all. If you can move the kbdev capability stuff into the 
kbutils function itself, at least for the RZUSBSTICKs, I'll add the rest. Using 
the kbutils.capabilities functions, it should be (at least that was the goal) 
portable across different devices.

Original comment by rmspe...@gmail.com on 21 Feb 2012 at 2:09

[GoogleCodeExporter]

Alright, I've created another patch.  This one is for the newest version of 
Killerbee and adds the 'Capabilities' information into the kbutils.devlist 
function.  It pulls from the DEVICE_CAPABILITIES variable and adds ['UNKNOWN'] 
when not available just like the scapy patch I originally submitted.

Once the scapy patch has been committed I can update the kbdev function to use 
the newest version of the kbutils.devlist, because I thinking adding that in 
now would complicate the patch situation since the scapy patch is for an older 
version.

Thanks!

Original comment by zeroStei...@gmail.com on 24 Feb 2012 at 3:28

Attachments:

• killerbee_capabilities.patch

[GoogleCodeExporter]

Merged and committed per r29. Worked smoothly during testing. If any issues are 
discovered, particularly any that break functionality, please report those ASAP 
so we can get them fixed. Thanks!

Original comment by melgares on 24 Feb 2012 at 1:51

[GoogleCodeExporter]

Thanks for making the commit, I didn't notice anything wrong in the patch.  
I'll try to test the functionality a little more in depth over the next few 
days though.

Original comment by zeroStei...@gmail.com on 24 Feb 2012 at 3:14

[GoogleCodeExporter]

There will be an update soon to Scapy's dot15d4 module that you rely on.  File 
is attached. Can you confirm if this breaks any  of your code? I'm concerned 
about the ZigbeeSecurityHeader modifications.

Original comment by rmspe...@gmail.com on 17 Mar 2012 at 3:08

Attachments:

• dot15d4.txt

[GoogleCodeExporter]

Marking completed. Will reopen if QA issues.

Original comment by rmspe...@gmail.com on 17 Jun 2012 at 5:39

• Changed state: Fixed