search

monken / cfn-include

Preprocessor for CloudFormation templates with support for loops and flexible include statements
MIT License
86 stars 10 forks source link

Lodash merge is limited #42

Closed nmccready closed 3 years ago

nmccready commented 3 years ago

Big down side is Arrays are not merged correctly upon deep merge. I believe _.merge should be swapped out for deepmerge. issue: https://stackoverflow.com/questions/39246101/deep-merge-using-lodash https://www.npmjs.com/package/deepmerge

monken commented 3 years ago

This would be a breaking change since some people might rely on this behavior. We could add a Fn::DeepMerge function?

nmccready commented 3 years ago

Yes this would be more than acceptable. I'd rather not have to fork this library :D

nmccready commented 3 years ago

I have a PR coming almost done

nmccready commented 3 years ago

Done https://github.com/monken/cfn-include/pull/43

nmccready commented 3 years ago

Anyway this can be looked at today? Sorry just trying to decide if I need to publish this under my own scope for now .

nmccready commented 3 years ago

@monken any 👀 on this yet?