monkey / monkey

Monkey HTTP Server
http://monkey-project.com
Apache License 2.0
627 stars 171 forks source link

Can't set to non-blocking the socket when compiled with ACCEPT_GENERIC (Trac #51) #35

Closed edsiper closed 10 years ago

edsiper commented 10 years ago

The problem is most likely that in liana.c line 61

(fcntl(server_fd, F_SETFL, fcntl(remote_fd, F_GETFD, 0) | O_NONBLOCK) == -1)

should be:

(fcntl(remote_fd, F_SETFL, fcntl(remote_fd, F_GETFD, 0) | O_NONBLOCK) == -1)

Migrated from http://bugs.monkey-project.com/ticket/51

{
    "status": "closed", 
    "changetime": "2011-03-30T21:23:55", 
    "description": "The problem is most likely that in liana.c line 61\n\n(fcntl(server_fd, F_SETFL, fcntl(remote_fd, F_GETFD, 0) | O_NONBLOCK) == -1) \n\nshould be:\n\n(fcntl(remote_fd, F_SETFL, fcntl(remote_fd, F_GETFD, 0) | O_NONBLOCK) == -1) \n\n", 
    "reporter": "pgas", 
    "cc": "", 
    "resolution": "fixed", 
    "_ts": "1301520235310662", 
    "component": "Unspecified", 
    "summary": "Can't set to non-blocking the socket when compiled with ACCEPT_GENERIC", 
    "priority": "major", 
    "keywords": "", 
    "version": "", 
    "time": "2011-03-30T17:50:30", 
    "milestone": "", 
    "owner": "edsiper", 
    "type": "defect"
}
edsiper commented 10 years ago

Trac update at 20110330T21:23:55:

good catch!, the fix have been pushed to the repo:

http://git.monkey-project.com/?p=monkey;a=commitdiff;h=a1b29ab0129b41d9e53772bcd26d0009a30c3e04

thanks!

  • edsiper changed resolution from "" to "fixed"
  • edsiper changed status from "new" to "closed"