feat: support async start

monkeyWie / proxyee

HTTP proxy server,support HTTPS&websocket.MITM impl,intercept and tamper HTTPS traffic.

MIT License

1.52k stars 572 forks source link

Closed siwee closed 3 years ago

siwee commented 3 years ago

Signed-off-by: aomsweet aomsweet@tutanota.com

monkeyWie commented 3 years ago

谢谢PR，不过觉得这样做没有太大的必要，如果要异步的话可以自己开个线程跑就行了

siwee commented 3 years ago

当然开个线程肯定是可以的，只是没有必要多开一个线程呀。哈哈😄

monkeyWie commented 3 years ago

要不你改一下，之前的start方法不动，加一个startAsyn方法来实现，保持向下兼容性

siwee commented 3 years ago

嗯也行

siwee commented 3 years ago

@monkeyWie 已经针对您的建议修改了代码，增加了startAsync()启动方法，同时保留原来start()方法的阻塞行为。

monkeyWie commented 3 years ago

@aomsweet 辛苦了~

siwee commented 3 years ago

谢谢☕

monkeyWie commented 3 years ago