Add some builder-like support to appropriate classes

monkeyWie / proxyee

HTTP proxy server,support HTTPS&websocket.MITM impl,intercept and tamper HTTPS traffic.

MIT License

1.52k stars 572 forks source link

Add some builder-like support to appropriate classes #193

Closed er1c closed 2 years ago

er1c commented 2 years ago

Hi,

This might break some binary compatibility. If you prefer I can add separate *Builder classes (e.g. I can add a HttpProxyServerConfigBuilder.java)

Thank you for your great work!

Best Regards,

Eric

monkeyWie commented 2 years ago

Thank for your PR, this is a break change, I will merge it at major version change.

er1c commented 2 years ago

Thank for your PR, this is a break change, I will merge it at major version change.

Yes, I made sure to mention that!

What do you think about adding a HttpProxyServerConfigBuilder to maintain binary compatibility?

monkeyWie commented 2 years ago

I think it's OK that add a Builder class, so if we have a Builder class, it can replace this PR.

er1c commented 2 years ago

@monkeyWie I updated this PR to include the Builder without changing the binary compatibility

monkeyWie commented 2 years ago

Nice!