Add crossorigin attribute to stylesheet

monkeyWzr / hugo-theme-cactus

Cactus theme for hugo

MIT License

537 stars 338 forks source link

Add crossorigin attribute to stylesheet #86

Closed andodet closed 3 weeks ago

andodet commented 3 years ago

First of all thanks for the neat theme. I've added a crossorigin attribute (following this post) to the stylesheet link as it looks the only solution to a problem I am currently facing and seems it's a shared approach on other themes as well.

monkeyWzr commented 3 years ago

@andodet Thanks for helping! But the commit 07caffb which includes crossorigin attribute seems to be force-overwritten by 8351bf4, which removes the Integrity attribute. Can you check it again? Thanks!

leonseng commented 3 years ago

I ran into the same issue and resolved it by adding the crossorigin="anonymous" attribute. Any preference on which method do you want to proceed with, @monkeyWzr ?

andodet commented 3 years ago

Sorry for the slow reply. @leonseng approach didn't work for me (I believe for unrelated reasons) - at the same time I believe that would be the correct approach to handle this.