search

monkeyboard / Wiegand-Protocol-Library-for-Arduino

Wiegand 26 and Wiegand 34 Protocol Library for Arduino
323 stars 131 forks source link

Add conditional ICACHE_RAM_ATTR for interrupt handler on ESP8266 #38

Closed beikeland closed 4 years ago

ccfiel commented 4 years ago

why is this not merge?

ccfiel commented 4 years ago

@beikeland still got the error even I apply your PR.

beikeland commented 4 years ago

@beikeland still got the error even I apply your PR.

my guess would be your code uses other interrupt service routines that also need the same change

why is this not merge?

inactive maintainer?

ccfiel commented 4 years ago

@beikeland If I remove the code below the error stops. 

  wg.begin(5, 4);

so i think its in the wiegand lib

beikeland commented 4 years ago

Then the only other possibility is that you're using the master branch of my repo instead of the branch where i applied the fix? https://github.com/beikeland/Wiegand-Protocol-Library-for-Arduino/tree/esp-icahce

or maybe your toolchain somehow doesn't set the ESP8266 pre prosessor variable? Arduino 1.8.9 does at least.

ccfiel commented 4 years ago

@beikeland you right :) thanks!

frenchie71 commented 4 years ago

Ooops sorry, had not seen your pull request - I somehow requested the same ;-)