search

monkeyman192 / MBINCompiler

A tool for decompiling No Man's Sky .MBIN files to XML format
https://monkeyman192.github.io/MBINCompiler
Other
249 stars 49 forks source link

Un/Supported Structs #41

Closed GaticusHax closed 5 years ago

GaticusHax commented 6 years ago

If libMBIN stored some information about what structs have known issues, it would be possible to detect unsupported files and report it to the user. This would help to avoid many unnecessary bug reports for structs that have yet to be updated.

monkeyman192 commented 6 years ago

I think maybe making this an attribute would be the best way to handle it? The thing is it isn't always known what is broken and what isn't. Like, if I know that a struct is broken, I would fix it...

GaticusHax commented 5 years ago

We can make this work fairly easily now.

With each struct having a GUID, we can use a Broken NMSAttribute parameter to indicate files with known issues, such as METADATA\INPUTTEST.MBIN.

When NMS is updated, all changed structs can be me marked with the Broken property pending their fixes. That will allow for updates to be released while some structs are waiting to be updated.

MBINCompiler can be updated to detect both the GUID and Broken flags and warn the user that the files are unsupported.

monkeyman192 commented 5 years ago

sounds good to me :)

GaticusHax commented 5 years ago

I think we can call this done.