monkeyman192 / MBINCompiler

A tool for decompiling No Man's Sky .MBIN files to XML format
https://monkeyman192.github.io/MBINCompiler
Other
238 stars 49 forks source link

Intermixed info in log file when processing multiple files #564

Open HolterPhylo opened 10 months ago

HolterPhylo commented 10 months ago

Describe the bug Intermixed info in log file when processing multiple files

Expected behavior Each processed file info in its block of text

Steps To Reproduce Process a large amount of files that generate a mix of WARN and/or ERR as well as no WARN/ERR (just INFO lines)

Specs (please complete the following information, if applicable):

Attachments: see example log output MBINCompiler.log Screenshot - 2023-08-14 , 22_37_44 Screenshot - 2023-08-14 , 22_37_22 Screenshot - 2023-08-14 , 22_35_02 ![Screenshot - 2023-08-14 , 22_31_14](https ![Screenshot - 2023-08-14 , 22_30_57](https://gith Screenshot - 2023-08-14 , 22_13_52 ub.com/monkeyman192/MBINCompiler/assets/3037251/c5a28a20-4c16-478d-8f21-e8b735a3b51a) ://github.com/monkeyman192/MBINCompiler/assets/3037251/103d1393-faf7-4210-b49b-d13c154f437e) Screenshot - 2023-08-14 , 16_59_14

HolterPhylo commented 10 months ago

Also, this happens: missing 2 spaces in front of lines 18-19 on the left that are normally like the ones on the right. This with what happens above makes parsing for the right filename of the reported ERROR/WARNING very hit and miss. Screenshot - 2023-08-28 , 10_16_39

cmkushnir commented 10 months ago

If mbinc is processing mult mbin in parallel then messages written to single log will be mixed. The easiest way to prevent this is to have each mbin instance maintain its own log (list) of messages, then write them all to the log once the mbin finishes processing. The write to the log would be serialized, so although all messages for a given mbin would be together the order that the mbin's are reported would be random (depends when a thread finishes a given mbin). If you want mbin's in order as well then wait until all mbin's finish then write to log, however, then carrying state around for each mbin after it's finished which won't scale well ... though for this case would likely be ok. Other issue is if crash, then won't have messages in log upto crash point.

HolterPhylo commented 10 months ago

Thanks for comment. Keeping the order of the files processing is not important. Keeping the information of each file process together is what counts, not all intermixed with other files output