search

monkeyman192 / MBINCompiler

A tool for decompiling No Man's Sky .MBIN files to XML format
https://monkeyman192.github.io/MBINCompiler
Other
241 stars 49 forks source link

Add the MissionBoardRewardOptions enum back in #571

Open Lenni009 opened 10 months ago

Lenni009 commented 10 months ago

Is your feature request related to a problem? Please describe. In 4.40, HG removed the MissionBoardRewardOptions enum, so we have no clear way of knowing what each array item means. This specifically affects the DEFAULTREALITY.MBIN file, where this array is used.

Describe the solution you'd like Hardcode the enum members back in, like we have done with other enums as well.

Additional context Needs verification whether the array members actually correspond to the names we want to give them.

Here's a diff between 4.38 (left) and 4.43 (right) DEFAULTREALITY.EXML: diff 4.38 vs 4.43

monkeyman192 commented 10 months ago

For context, the reason they were removed is because the enum we hard-coded to be associated with this array became a few elements bigger, and so no longer was able to be used with the array due to the size mismatch.

Babscoole commented 10 months ago

So, could be added back in, BUT, oldschool style, would need to test what each enum element now does/changes, in order to hardcode labels back in for them.