monkeytypegame / monkeytype

The most customizable typing website with a minimalistic design and a ton of features. Test yourself in various modes, track your progress and improve your speed.
https://monkeytype.com/
GNU General Public License v3.0
15.53k stars 2.35k forks source link

"japanese hiragana" keymap issues #5968

Open TBBle opened 5 days ago

TBBle commented 5 days ago

Did you clear cache before opening an issue?

Is there an existing issue for this?

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

TBBle

Account config

{"theme":"solarized_dark","themeLight":"serika","themeDark":"serika_dark","autoSwitchTheme":false,"customTheme":false,"customThemeColors":["#323437","#e2b714","#e2b714","#646669","#2c2e31","#d1d0c5","#ca4754","#7e2a33","#ca4754","#7e2a33"],"favThemes":["solarized_dark"],"showKeyTips":true,"smoothCaret":"medium","quickRestart":"enter","punctuation":false,"numbers":false,"words":50,"time":120,"mode":"time","quoteLength":[1],"language":"japanese_hiragana","fontSize":2,"freedomMode":false,"difficulty":"normal","blindMode":false,"quickEnd":false,"caretStyle":"default","paceCaretStyle":"default","flipTestColors":false,"layout":"default","funbox":"none","confidenceMode":"off","indicateTypos":"below","timerStyle":"mini","liveSpeedStyle":"off","liveAccStyle":"off","liveBurstStyle":"off","colorfulMode":false,"randomTheme":"off","timerColor":"main","timerOpacity":"1","stopOnError":"off","showAllLines":false,"keymapMode":"next","keymapStyle":"staggered","keymapLegendStyle":"dynamic","keymapLayout":"japanese_hiragana","keymapShowTopRow":"always","keymapSize":1,"fontFamily":"Fira_Code","smoothLineScroll":false,"alwaysShowDecimalPlaces":false,"alwaysShowWordsHistory":false,"singleListCommandLine":"on","capsLockWarning":true,"playSoundOnError":"4","playSoundOnClick":"1","soundVolume":0.5,"startGraphsAtZero":true,"showOutOfFocusWarning":true,"paceCaret":"off","paceCaretCustomSpeed":100,"repeatedPace":true,"accountChart":["on","on","on","on"],"minWpm":"off","minWpmCustomSpeed":100,"highlightMode":"letter","typingSpeedUnit":"wpm","ads":"result","hideExtraLetters":false,"strictSpace":false,"minAcc":"off","minAccCustom":90,"monkey":false,"repeatQuotes":"off","oppositeShiftMode":"off","customBackground":"","customBackgroundSize":"cover","customBackgroundFilter":[0,1,1,1],"customLayoutfluid":"qwerty#dvorak#colemak","monkeyPowerLevel":"off","minBurst":"off","minBurstCustomSpeed":100,"burstHeatmap":false,"britishEnglish":false,"lazyMode":false,"showAverage":"off","tapeMode":"off","maxLineWidth":0}

Current Behavior

Some issues with the Japanese keymap display for kana-input usage:

As an example of the "next" key issues, if the next word to type is すずめ:

Expected Behavior

In the keymap

In example of the "next" key issues, if the next word to type is すずめ:

Steps To Reproduce

  1. Enable Kana input and select Hiragana mode in the Microsoft IME
  2. Load the supplied config. Specifically, enables "next" mode keymap with the "japanese hiragana" keymap layout and dynamic legend.
  3. Note the absence of the ろ key in the top row, it should appear to the left of ぬ (`\~ key in US English)
  4. Note the absence of the ー key in the bottom row, it should appear to the right of へ (\| key in US English)
  5. Start a "japanese hiragana" test
  6. Note that no key highlight is shown when the next character to type has a marker.
  7. Note that when the next key input is expected to be a marker, the next character's key is highlighted instead.

Environment

Anything else?

This keyboard layout is actually an ANSI 104-key emulation of a full OADG 109-key keyboard, which has a slightly different layout for some of the keys. It'd be nice to add another keyboard layout that matches the full OADG109A layout, but that's actually a separate issue (feature request/future simple PR) but which might expose more layout issues as it needs another key in the bottom row.

Also, I had a quick look, and it looks like the missing ろ and む keycaps are in the layout data file, so that part must be a limitation elsewhere.

TBBle commented 5 days ago

Keys in the data file but not shown on the keymap appears to be a generic problem: On examination, even the "qwerty" layout suffers from this, not showing the ` or \ keys.