monlovesmango / astral

Nostr client made with Quasar
https://astral.ninja
MIT License
101 stars 38 forks source link

WebTorrent Support? #74

Open leesalminen opened 1 year ago

leesalminen commented 1 year ago

Hi there,

Wondering what the maintainers of astral think about adding web torrent support to the client? Meaning:

Am open to contributing this to astral, just want to know if folks are amenable to this or no.

monlovesmango commented 1 year ago

hey! this is an interesting idea but i'm not sure I want to support this at this moment. I do agree that some sort of media support is needed, however this option is a bit niche (for example, I don't have a torrent client haha). I'd rather put my effort behind a media option based on self hosting thats accessible to everyone.

leesalminen commented 1 year ago

Hi there,

Just to clarify here, WebTorrent works entirely in the browser with pure JS. Users aren’t required to have any standalone software, or take any additional steps at all, to use WebTorrent.

Basically astral would include a JS package which turns your browser into a torrent client.

100% agree that whatever the solution is, it needs to be accessible to anyone.

Check out https://github.com/webtorrent/webtorrent for docs and https://instant.io for demo.

monlovesmango commented 1 year ago

ok i'm listening (and clearly don't know much about torrents). will review both of these when I get time.

I am in the process of creating a traditional self hosted media server that integrates with astral based on nip05 in rust. see https://github.com/monlovesmango/hostr. how hard is it to retrofit traditional media server to use torrent instead?

kimico commented 1 year ago

Hey @leesalminen :) how are you?

I started doing something (Lol About ME) and I still didn't have this context.

https://astral.ninja/note15v47k09w4ap444yr04gx08am2e470m9p48al8cl83tkdagaraz5sr8rdhz

This is my progress, what do you think of the idea?:

https://github.com/kimico/astral/commit/4bdaf37b3f0f988fe1233cb862a951c850e3d6e9

Do you already have any code?

I see some challenges(i'm ignoring it), like making sure "your media" doesn't disappear (peer count helps with that) but i will keep it simple.

leesalminen commented 1 year ago

Hey @leesalminen :) how are you?

I started doing something (Lol About ME) and I still didn't have this context.

https://astral.ninja/note15v47k09w4ap444yr04gx08am2e470m9p48al8cl83tkdagaraz5sr8rdhz

This is my progress, what do you think of the idea?:

kimico@4bdaf37

Do you already have any code?

I see some challenges(i'm ignoring it), like making sure "your media" doesn't disappear (peer count helps with that) but i will keep it simple.

come join us here: https://github.com/damus-io/damus/discussions/272