search

monmohan / dsjslib

A library implementing several standard data structures and utilities, in JavaScript. Its written and tested using Node.js which is the target platform.
MIT License
773 stars 68 forks source link

Fixed a bug in CircularBuffer.entries() and some minor additions #5

Closed emil-mi closed 10 years ago

emil-mi commented 10 years ago

Fixed a bug in CircularBuffer.entries() that returned an empty list when _end was not aligned with the internal buffer. Also modified entries() to use calls to slice() and concat() instead of a while loop and push()

monmohan commented 10 years ago

thanks . I have merged it. Monmohan

On Fri, Jan 31, 2014 at 8:49 PM, Emil Mieilica notifications@github.comwrote:

Fixed a bug in CircularBuffer.entries() that returned an empty list when _end was not aligned with the internal buffer. Also modified entries() to

use calls to slice() and concat() instead of a while loop and push()

You can merge this Pull Request by running

git pull https://github.com/emil-mi/dsjslib master

Or view, comment on, or merge it at:

https://github.com/monmohan/dsjslib/pull/5 Commit Summary

  • Fixed a bug in CircularBuffer.entries() that returned an empty list when _end was not aligned with the internal buffer. Also modified entries() to use calls to slice() and concat() instead of a while loop and push()

File Changes

  • M lib/CircularBuffer.jshttps://github.com/monmohan/dsjslib/pull/5/files#diff-0(24)
  • M tests/TestCircularBuffer.jshttps://github.com/monmohan/dsjslib/pull/5/files#diff-1(57)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/monmohan/dsjslib/pull/5 .

nickpoorman commented 10 years ago

Did this patch make it into the npm repo?

monmohan commented 10 years ago

Hi Nicholas, Unfortunately, not yet. I was planning to do that after I am done with Graph support in the library but that is taking some time. So, I think I will push these changes to npm sooner (today or tomorrow).

Regards Monmohan

On Mon, Mar 17, 2014 at 11:09 PM, Nicholas Poorman <notifications@github.com

wrote:

This this patch make it into the npm repo?

— Reply to this email directly or view it on GitHubhttps://github.com/monmohan/dsjslib/pull/5#issuecomment-37846074 .

monmohan commented 10 years ago

This patch is now available on npm repo (as well as basic Graph functionalilty, yet to be documented)