search

monmouth-college-cs / sddc-reading-notes-monmouth-college-comp-335

sddc-reading-notes-monmouth-college-comp-335 created by GitHub Classroom
0 stars 0 forks source link

Basic Workflow Update. #25

Open LukasNilsson opened 5 years ago

LukasNilsson commented 5 years ago
  1. Clone Repository
  2. Switch to EmptyBranch (git checkout EmptyBranch)
  3. Make your new Branch (git checkout -b NameCh#-Branch)
  4. Make your Markdown doc (Ch#Third#(Summaries/Questions).md (e.g. Ch4Third2Questions.md, Ch5Third1Summaries.md))
  5. git add filename.md
  6. git commit filename.md
  7. git push origin NameCh#-Branch
  8. Make pull request on GitHub from Name-Branch to Chapter# (make sure the arrow points in the right direction)
  9. Comment on others’ pull requests
  10. Improve your markdown doc based on comments on your pull request
  11. git add filename.md
  12. git commit filename.md
  13. git push origin NameCh#-Branch
  14. Merge your pull request
  15. Make your summary of summaries markdown (Ch#SoSName.md)
  16. Repeat steps 5-8
  17. Merge your pull request on GitHub
  18. Vote on Sos
  19. Comment on pull request into master

Edits: Added naming convention Included Davids comments Added commits Update naming convention Add 18. Reordered 15 and 16

Please bug fix with comments

davidhsonic commented 5 years ago

Making a new branch is git checkout -b Name-Branch.

davidhsonic commented 5 years ago
  1. Make pull request on GitHub from Name-Branch to Chapter# (make sure the arrow points in the right direction)
  2. Comment on others’ pull requests
  3. Improve your markdown doc based on comments on your pull request
  4. git add filename.md
  5. git push origin Name-Branch
  6. Merge your pull request on GitHub
  7. Add your summary of summaries to filename.md
  8. Repeat steps 5-12
  9. Comment on pull request into master
LukasNilsson commented 5 years ago

I think we should have naming conventions for consistency. I just put (Name-Ch#-Notes.md) because that seems the way we were going. Work for everyone? We can start on CH4, e.g Lukas-Ch4-Notes.md

davidhsonic commented 5 years ago

The naming convention that would make putting the notes together the most convenient for me would probably be Ch#Third#(Summaries/Questions).md (e.g. Ch4Third2Questions.md, Ch5Third1Summaries.md). Maybe put names at the end if you want (e.g. Ch4Third2QuestionsLukas.md).

Also, you modified step 2 when you shouldn't have.

davidhsonic commented 4 years ago

I'd prefer if the SoS's were named Ch#SoSName.md instead of NameCh#SOS.md

And I don't think step 18 should be there anymore. I think we decided against that.