[build] remove anything related to AppVeyor

mono / Embeddinator-4000

Tools to turn .NET libraries into native libraries that can be consumed on Android, iOS, Mac, Linux and other platforms.

MIT License

758 stars 95 forks source link

[build] remove anything related to AppVeyor #666

Closed jonathanpeppers closed 6 years ago

jonathanpeppers commented 6 years ago

As part of consolidating our CI setup, we now have Windows builds running on Jenkins. This means we no longer need to use AppVeyor at all, which is a good thing. AppVeyor is not a CI system well known by other folks working on the Xamarin or Mono teams, where Jenkins is mostly used.

Other changes:

Updated .gitignore for files appearing on Windows: UpgradeLog.htm from VS upgrading projects and *.obj from running the C tests

spouliot commented 6 years ago

Globally: I'm not a fan of mixing different things in a single PR / commit. It makes reverts, merges and cherry-picks harder that they need to be. Is there a reason to include both changes in the same commit ?

Separately:

Removing AppVeyor 👍 - because I understand why, but it's not mentioned in the commit message (and my future self might not remember).
Changing line endings... maybe but why ? we're losing git history of those files (negative) without knowing what this solves or help (no positive).

spouliot commented 6 years ago

oh, now I see (reading the PR number) 🙈