Closed himanshugoel2797 closed 8 years ago
Hey @himanshugoel2797, Thank you for your Pull Request! We <3 our contributors!
However, it looks like you haven't signed our CLA (Contributor License Agreement) yet. In order for us to accept your pull request, you have to sign our CLA first. Once you do this, we can check over your pull request. You should only have to do this once.
You can read and sign our full Contributor License Agreement here.
Thanks,
Your friendly Xamarin CLA Bot#
Note: this doesn't build yet
Hey @himanshugoel2797,
Thanks for signing our CLA! We can now look at your pull request.
Always at your service,
Your friendly Xamarin CLA Bot#
Hey @himanshugoel2797,
thanks for looking into this. I have fixed the build to work with the updated vk.xml spec meanwhile.
The part you are fixing should go to the Windows platform, so once you fix it, the VK_NV_external_memory_win32 extension should be added to the Windows platform (see https://github.com/mono/VulkanSharp/blob/master/tools/Generator/Generator.cs#L2066)
The unknown counters can be added to the fieldCounterMap (see https://github.com/mono/VulkanSharp/blob/master/tools/Generator/Generator.cs#L472)
Please let me know if you are interested in finishing fixing it or if I should take a look at it.
Ah sorry, I completely forgot about this, I'm sorry but I don't think I'll be able to finish this.
Thanks for letting me know.
Hello! I'm the build bot for the Mono project.
I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done.
Contributors can ignore this message.