search

mono / VulkanSharp

Open source .NET binding for the Vulkan API
MIT License
538 stars 61 forks source link

Generator Update to better handle FlagBits + Extension #56

Closed bholcomb closed 7 years ago

bholcomb commented 7 years ago

This pull request changes the code generator for handling FlagBits when there is an extension after the type name. This resolves issue #55.

monojenkins commented 7 years ago

Hello! I'm the build bot for the Mono project.

I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done.

Contributors can ignore this message.

xamarin-cla-bot commented 7 years ago

Hey @bholcomb, Thank you for your Pull Request! We <3 our contributors!

However, it looks like you haven't signed our CLA (Contributor License Agreement) yet. In order for us to accept your pull request, you have to sign our CLA first. Once you do this, we can check over your pull request. You should only have to do this once.

You can read and sign our full Contributor License Agreement here.

Thanks,

Your friendly Xamarin CLA Bot#

xamarin-cla-bot commented 7 years ago

Hey @bholcomb,

Thanks for signing our CLA! We can now look at your pull request.

Always at your service,

Your friendly Xamarin CLA Bot#

radekdoulik commented 7 years ago

For some reason github didn't attach my comments to the relevant lines. Please look at https://github.com/bholcomb/VulkanSharp/commit/bd79df4eaf951ade714f924cad773f5f57167486 comments.

bholcomb commented 7 years ago

I made the requested changes in my branch, I think I got everything you were looking for. Let me know if you would like me to change anything.

I would like somebody to look at what I did for how the generator handles RROutput and Display structs since I wasn't quite sure what I did was the right thing.

radekdoulik commented 7 years ago

Thanks for the update.

I think it would be better to rename the new CheckFlagBitsName method to something like GetFlagBitsName because in current implementation it also returns the updated name.

Please also fix the method calls indentation and blocks indentation so that it looks like rest of the code. (so like protected string GetFlagBitsName (string name) and the { braces on the same line as if, foreach, ...)

Please don't add new code to this PR and rather open new one for it (the Display, NN, ... changes).

It would also help if you could squash the generator changes to one patch and regenerated bindings to another. (use git rebase -i)

bholcomb commented 7 years ago

Opening a new pull request with a squashed commit