search

mono / VulkanSharp

Open source .NET binding for the Vulkan API
MIT License
538 stars 61 forks source link

Update Generator.cs #60

Closed realvictorprm closed 6 years ago

realvictorprm commented 7 years ago

Make Handle public to make it usable for other libraries.

monojenkins commented 7 years ago

Hello! I'm the build bot for the Mono project.

I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done.

Contributors can ignore this message.

xamarin-cla-bot commented 7 years ago

Hey @realvictorprm, Thank you for your Pull Request! We <3 our contributors!

However, it looks like you haven't signed our CLA (Contributor License Agreement) yet. In order for us to accept your pull request, you have to sign our CLA first. Once you do this, we can check over your pull request. You should only have to do this once.

You can read and sign our full Contributor License Agreement here.

Thanks,

Your friendly Xamarin CLA Bot#

xamarin-cla-bot commented 7 years ago

Hey @realvictorprm,

Thanks for signing our CLA! We can now look at your pull request.

Always at your service,

Your friendly Xamarin CLA Bot#

radekdoulik commented 7 years ago

I am sorry for late my reply. Thank you for the patch!

The patch doesn't work though, as the Handle is defined explicitly and we would get CS0106 errors. Luckily we don't need to define it explicitly (anymore?), so we just need to modify you patch slightly to:

IndentWriteLine ("public {0} Handle {{", handleType);

Could you please fix your PR? (make sure it still has 1 commit)

realvictorprm commented 7 years ago

Sure @radekdoulik :smiley:! The fix was a guess afterwards I looked into the sourcecode. However it already looked to easy to be correct. Nevertheless of course I'll fix it.

realvictorprm commented 7 years ago

I'm sorry now too @radekdoulik I had a lot to do and forgot making the small edit. Please excuse this!

taspeotis commented 7 years ago

The linked issue says I cannot access the handles of the classes without using ... reflection but if it's just explicit interface implementation you need neither public nor reflection.

var handle = ((IMarshalling) instance).Handle;
realvictorprm commented 6 years ago

@taspeotis I think the change was made meanwhile so this was back then not valid anymore.

Closing this now :)