Some more samples and fixes in samples

mono / VulkanSharp

Open source .NET binding for the Vulkan API

MIT License

537 stars 61 forks source link

Some more samples and fixes in samples #69

Closed TillAlex closed 6 years ago

TillAlex commented 6 years ago

As Vulkan code should be mostly platform independent platform dependent and independent code in samples was separated (0152794). This allows implementing the same samples for multiple platforms without code doubling.

Until now the XLogoSample and the ClearSample are implemented for Android and Windows (bb4fec3). As soon as MoltenVK is supported I will add iOS samples as well.

While testing the samples under Windows and Android I noticed that they are buggy. Testing with LunarG SDK shows multiple validation errors. 5801bb5 fixes those.

msftclas commented 6 years ago

All CLA requirements met.

TillAlex commented 6 years ago

Not sure why the CLA bot asks my to sign again. Already signed the agreement in #17

TillAlex commented 6 years ago

Signed it again now...

radekdoulik commented 6 years ago

We have new CLA bot as the old one was deprecated, sorry for the inconvenience.

TillAlex commented 6 years ago

Just found that I checked in SampleBase in the last commit although there are only white space fixes in that file. If you want me to I can prepare another pull request without that changes.

radekdoulik commented 6 years ago

No need for another PR. Just add more commits here and I will squash it before merge, or force push updated commits to your branch.

TillAlex commented 6 years ago

Just added another commit. I fixed lots of white space issues, hope I found them all. I changed the directory structure according to the AnalogClock example.