search

mono / api-doc-tools

.NET Reference API Toolchain
MIT License
68 stars 48 forks source link

[mdoc] Multitarget net471 and net6.0 #639

Closed pjcollins closed 2 years ago

pjcollins commented 2 years ago

Adds net6.0 as a target framework to mdoc. The artifacts from the net6.0 build will be output to bin/$(Configuration)-net6.0.

Mono.Cecil has been bumped from 0.10.0-beta5 to 0.10.0. This update appears to have introduced a change in behavior in F# doc generation, and the expected output in PatternMatchingExamples.xml has been updated to reflect that.

The mdoc NuGet package has been updated to include both net471 and net6.0 tools. This can be considered a breaking change, as the path of mdoc.exe has been changed to include a folder named after its target framework.

huangmin-ms commented 2 years ago

Thanks @pjcollins would you mind also upgrading mdoc.test.csproj to net6？

huangmin-ms commented 2 years ago

@pjcollins Thank you! I noticed that we have to introduce conditional compilation for some files just for net6. Since it's just a test project, maybe we can stay with net471 for now. any thoughts?

pjcollins commented 2 years ago

@huangmin-ms I think it makes sense to at least have some tests running against the net6.0 version of mdoc, we gain that new test coverage by running the net6.0 version of mdoc.Test.dll. Maybe we could file an issue that mentions the tests ignored for net6.0 to see if they can be re-enabled in the future.

huangmin-ms commented 2 years ago

@pjcollins Thanks for your contribution! Really appreciate it!