Another Android+clang assembly build fix

mono / boringssl

Custom version of Boring SSL used by Mono

Other

6 stars 21 forks source link

Another Android+clang assembly build fix #16

Closed grendello closed 5 years ago

grendello commented 5 years ago

This time for clang from an older NDK (14b) which not only needs the previous fix to enable the crypto extensions but it also needs NEON to be explicitly enabled in order to avoid errors similar to:

ghashv8-armx.S:14:2: error: instruction requires: neon
 movi v19.16b,#0xe1

lewurm commented 5 years ago

I assume you have tested that, right?

I'm a bit surprised, because neon is an instruction set extension for <= ARMv7. It's also not listed in the GCC options for ARMv8: https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html (can't find the according docs for clang 😕 )

grendello commented 5 years ago

Yes, I tested it. The fix is for clang shipped with NDK r14, it's some version of clang 3 I think - probably a bug in it. +neon wasn't necessary for the NDK r18's clang version.