search

mono / gtk-sharp

Gtk# is a Mono/.NET binding to the cross platform Gtk+ GUI toolkit and the foundation of most GUI apps built with Mono
http://www.mono-project.com/GtkSharp
Other
429 stars 140 forks source link

gdk: Use platform independent ptr type in gdk_net_client_list #117

Closed riccioclista closed 8 years ago

riccioclista commented 10 years ago

This is a PR for the gtk-sharp-2-12-branch

This fixes XamBug #176, which results from incompatible pointer sizes on different CPU architectures.

monoadmin commented 10 years ago

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

monoadmin commented 10 years ago

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

monoadmin commented 10 years ago

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

Therzok commented 10 years ago

approve

Therzok commented 10 years ago

Oh, ignore the jenkins bot, it seems that there's no configuration for the 2.12 branch.

directhex commented 10 years ago

I'll have a think about how to make the Jenkins job work for both master and the branch tomorrow. commenting so I don't forget.

directhex commented 10 years ago

build

directhex commented 10 years ago

build

Therzok commented 8 years ago

Looks safe enough to merge.

zDougie commented 8 years ago

I was having the same issue but then noticed that Therzok reference 2-12. I switched from 3.0 to 2.12 and worked good.

Will you be changing 3.0 too? [new here, so perhaps I'm in the wrong place]. Thanks,

knocte commented 8 years ago

@zDougie: thanks for bringing this up. Since you were the only which noticed this so far, can you open the PR for master branch yourself? Thanks!

Therzok commented 8 years ago

@knocte There is no gdk/glue/windowmanager.c in master.