search

mono / gtk-sharp

Gtk# is a Mono/.NET binding to the cross platform Gtk+ GUI toolkit and the foundation of most GUI apps built with Mono
http://www.mono-project.com/GtkSharp
Other
428 stars 140 forks source link

[Gen] Always free strdup strings as they're not held by native #163

Closed Therzok closed 7 years ago

Therzok commented 7 years ago

This fixes a few leaks caused by gstrdup-ing by firing and forgetting.

https://gist.github.com/Therzok/822d377e69476d172f434aa79ef74aed

Therzok commented 7 years ago

cc @DavidKarlas @alanmcgovern

Therzok commented 7 years ago

Actually, some of these bindings look incorrect. The char stuff should take in a simple char, gtk_label_get should be using an out string, ParseArgs should be using a ref array.

Only the paint/draw/pango stuff seem to be generated correctly now

Therzok commented 7 years ago

Updated diff because the previous comment is now obsolete as the fixes have to the API have landed: https://github.com/mono/gtk-sharp/commit/22952685e11ac884b7a1d8312f14684825eee407 https://github.com/mono/gtk-sharp/commit/f66a1c84e0d6782340844dcb4feaa3e3871219c7 https://github.com/mono/gtk-sharp/commit/8abc2bab4791f205b3512bb2076469775fd3a49b