Closed Therzok closed 7 years ago
LGTM except that the gtk_widget_get_window symbol was introduced in GTK+ 2.14, so the minimum build dependency of GTK+ needs to be bumped from 2.12.0 to 2.14.0 in this change as well.
Sounds good to me, @meebey thanks, I guess this will have to happen, as the leak is pretty severe for MonoDevelop.
Yeah sure, I don't see a problem with bumping the GTK+ version to 2.14 as that was released in 2008, so everybody is using a newer version at runtime anyhow :)
Superseded by #182
This fixes GdkWindow leaks when creating your own Window.
The underlying cause is actually setting the value without going via the property setter. That means that any kind of notification isn't being taken into account.
In other words, if anything dependent on the property notification of "window" to do ref-unref, it wouldn't trigger. Using the gtk methods instead of glue code makes the actual notification to trigger.