search

mono / gtk-sharp

Gtk# is a Mono/.NET binding to the cross platform Gtk+ GUI toolkit and the foundation of most GUI apps built with Mono
http://www.mono-project.com/GtkSharp
Other
428 stars 140 forks source link

[GLib] Value should not unset if type isn't set. #184

Closed Therzok closed 7 years ago

Therzok commented 7 years ago

This is a mirror of a patch in a glib newer than the one we distribute with Mono.

meebey commented 7 years ago

I am curious if this condition shows a glib/warning or critical message on the console?

Therzok commented 7 years ago

assertion 'G_IS_VALUE (value)' failed, but it's changed in glib 2.36 - https://github.com/GNOME/glib/commit/4b2d92a864f1505f1b08eb639d74293fa32681da

Better it be a NOP than trigger exceptions.

alanmcgovern commented 7 years ago

I presume we definitely want to do this instead of patching our glib? If so then 👍 to it!