[GLib] Avoid keeping a reference to the error

mono / gtk-sharp

Gtk# is a Mono/.NET binding to the cross platform Gtk+ GUI toolkit and the foundation of most GUI apps built with Mono

http://www.mono-project.com/GtkSharp

Other

424 stars 140 forks source link

[GLib] Avoid keeping a reference to the error #292

Closed Therzok closed 3 years ago

Therzok commented 3 years ago

The original impl did not take into account exceptions marshalling across thread boundaries so it could end up with the error being accessed after being disposed Fix this by querying the message in-place, and also clear the error after, to signal to glib that we've suceeded in recovering

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1247180

Therzok commented 3 years ago

@sevoku @mrward could you please take a look? This should fix the GException error when it's marshalled across thread boundaries.