search

mono / libgdiplus

C-based implementation of the GDI+ API
http://www.mono-project.com/
MIT License
335 stars 171 forks source link

Add GUnit-based tests #576

Closed qmfrederik closed 5 years ago

qmfrederik commented 5 years ago

This PR adds a bunch of tests ported from the corefx test suite to GoogleTest tests. A lot of the PRs I submitted recently were based on corefx tests failing on libgdiplus.

The main reason for using GUnit was the Visual Studio integration. A an added bonus, the syntax aligns nicely with xUnit, making it easy to port tests from C# to C.

akoeplinger commented 5 years ago

I'd be OK with adding it if we have a way to run the tests on Mac/Linux. Looks like upstream recommends building gtest from source: https://github.com/google/googletest/blob/master/googletest/README.md

qmfrederik commented 5 years ago

@akoeplinger I've integrated the gtests with the Makefile (hope I did that correctly); the tests are being run as part of the Jenkins build: https://jenkins.mono-project.com/job/test-libgdiplus-pull-request/885/label=debian-9-amd64/console

akoeplinger commented 5 years ago

Replaced by https://github.com/mono/libgdiplus/pull/607