mono / libgdiplus

C-based implementation of the GDI+ API
http://www.mono-project.com/
MIT License
334 stars 171 forks source link

Add bitmap flushing to gdip_bitmap_clone #604

Closed filipnavara closed 4 years ago

filipnavara commented 4 years ago

…to fix possible inconsistencies for drawing flipped images.

There were few usages of gdip_bitmap_clone with missing flush calls. Unfortunately there is zero code coverage for these paths. The chances of actually turning this into visible bug are thin. One would have to create an ARGB32 bitmap, draw into it and then try to paint it flipped into another bitmap. Adding the flush call down the stack is a safety precaution that should prevent any incorrect usage.