search

mono / libgdiplus

C-based implementation of the GDI+ API
http://www.mono-project.com/
MIT License
334 stars 171 forks source link

Add unit test for reading X and Y pixel density from EXIF data #612

Closed provegard closed 4 years ago

provegard commented 4 years ago

See 8c5b0d48317af4c6fd702a1372f58a487e934f67

Test cases added as part of trying to fix #611 before I realized that the current fix works, it's just not part of any released version.

I have verified that the test case fails correctly without the code added in 8c5b0d48317af4c6fd702a1372f58a487e934f67.

dnfclas commented 4 years ago

CLA assistant check
All CLA requirements met.

provegard commented 4 years ago

By the way, the test image is not mine, it's this one:

https://github.com/eugeneware/jpeg-js/blob/master/test/fixtures/tree-rgb.jpg

provegard commented 4 years ago

Please let me know if you think I should amend the PR with image source/licence information to better comply with the CLA.

akoeplinger commented 4 years ago

Yeah I'm not sure we can take that file as is so I created a variation of one of our existing test images and use it instead :)