search

mono / libgdiplus

C-based implementation of the GDI+ API
http://www.mono-project.com/
MIT License
334 stars 171 forks source link

Fix multiple memory leaks for GpBitmap image data #635

Closed filipnavara closed 4 years ago

filipnavara commented 4 years ago

gdip_bitmap_dispose was leaking the bitmap backing data for certain image formats. This is essentially the same issue as in https://github.com/mono/libgdiplus/commit/1afe4711f10bd52e14a4c7985eae7414eda4108c but on a different place. I now unified both of the places to use the same code.

immarvin commented 4 years ago

hi @filipnavara @akoeplinger , what is the latest libgdi+ release including this PR and https://github.com/mono/libgdiplus/pull/603? if not, do you have any planned date to release the libgdi+ with the fix? thanks we are suffering from the memory leak issue

akoeplinger commented 4 years ago

There's no release yet. @filipnavara do you think there are any leaks left you'd like to fix? I backported your latest ones to the release/6.0 branch already.

filipnavara commented 4 years ago

@akoeplinger There are some leaks left in the test code and the issue with font collection leaking. I am not too concerned about the test code. The font collection leaking was there for many years and it's not a huge deal when consumed by the System.Drawing code. I guess for release/6.0 it's good to go. I'd also like to finish reviewing the last pending PRs and get 6.1 out soon after.

akoeplinger commented 4 years ago

Ok sounds good, then I guess we can cut a 6.0 release soon.

n432sean commented 4 years ago

Please consider https://github.com/mono/libgdiplus/pull/646 for the imminent release.

akoeplinger commented 4 years ago

Ok, I tagged https://github.com/mono/libgdiplus/releases/tag/6.0.5