mono / libgdiplus

C-based implementation of the GDI+ API
http://www.mono-project.com/
MIT License
329 stars 171 forks source link

Fix memory leak when setting pen dash style from custom to predefined #648

Closed filipnavara closed 4 years ago

filipnavara commented 4 years ago

This fixes part of #647 that I complained about in comment.

I tested locally that Windows libgdiplus in fact resets the dash array on DashStyleCustom -> DashStyleDashDot -> DashStyleCustom transition done using GdipSetPenDashStyle. Following this transition GdipGetPenDashArray returns the Dash-Dot pattern and not the original custom one.

akoeplinger commented 4 years ago

The other pending builds actually finished and are green on Azure DevOps: https://dev.azure.com/dnceng/public/_build/results?buildId=618761&view=results