mono / mono

Mono open source ECMA CLI, C# and .NET implementation.
https://www.mono-project.com
Other
11.13k stars 3.83k forks source link

[netcore] Remove / Alter TargetFrameworkMonikers.Mono Attribute On CoreFX Tests #15185

Open steveisok opened 5 years ago

steveisok commented 5 years ago

A handful of CoreFX tests have this attribute attached to them. We should seek to remove or have a different TargetFrameworkMoniker under MonoVM as they are currently skipped.

[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "https://bugzilla.xamarin.com/show_bug.cgi?id=60568")]

The list can be found at:

https://github.com/dotnet/corefx/search?q=TargetFrameworkMonikers.Mono&unscoped_q=TargetFrameworkMonikers.Mono

marek-safar commented 5 years ago

Interesting, I think this should ideally work automatically as .NET 5 MonoVM should not identify as TargetFrameworkMonikers.Mono