Syntax highlighting regression

mono / monodevelop

MonoDevelop is a cross platform .NET IDE

http://www.monodevelop.com

2.84k stars 1.01k forks source link

Syntax highlighting regression #3436

Closed mhutch closed 6 years ago

mhutch commented 6 years ago

On master, syntax highlighting highlights far fewer things, which makes code readability much worse.

Here is 7.2 with the Monokai theme:

Here is master:

VS bug #568029

mhutch commented 6 years ago

For comparison, here's VS Code. I general I prefer MD 7.2, but rather quite like the highlighted operators in VS Code.

Therzok commented 6 years ago

This is mostly a result of switching highlighting from textmate to roslyn classification APIs. There are no equivalents whatsoever for User *

mhutch commented 6 years ago

@Therzok we can add them upstream

mhutch commented 6 years ago

The missing classification functionality has now been added to Roslyn: https://github.com/dotnet/roslyn/pull/24931

Therzok commented 6 years ago

Should be fixable once https://github.com/mono/monodevelop/pull/4101/files is in.

mkrueger commented 6 years ago

I added the fix to the PR - it's not much of an problem now roslyn has it. Seems to work well.

However we even got some more semantic colors enum members, constants and extension methods - the roslyn team had some suggestions what could be added :).

xamarin-release-manager commented 6 years ago

Fixed in version 7.6.0.122 (master)

Author: Kirill Osenkov Commit: 0b642af9e5131e86c5c689c9cc747f0ebfac6b9f (mono/monodevelop)

xamarin-release-manager commented 6 years ago

Fixed in version 7.5.0.853 (d15-7)

Pull Request #4159 merged by: Lluis Sanchez Author: mono Commit: da30061ffe6dc2ffe7ebd6dd17164b79618cb2cc (mono/monodevelop)

xamarin-release-manager commented 4 years ago

Fixed in version 8.6.0.802 (master)

Author: Kirill Osenkov Commit: 0b642af9e5131e86c5c689c9cc747f0ebfac6b9f (xamarin/monodevelop)