MonoDevelop build: redefine AssemblySearchPaths

[KirillOsenkov]

Currently AssemblySearchPaths is the default:

      {CandidateAssemblyFiles};
      ;
      {HintPathFromItem};
      {TargetFrameworkDirectory};
      {AssemblyFoldersFromConfig:C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\AssemblyFolders.config,v4.6.1};
      {Registry:Software\Microsoft\.NETFramework,v4.6.1,AssemblyFoldersEx};
      {AssemblyFolders};
      {GAC};
      {RawFileName};
      ..\..\..\build\bin\

and this is very bad, because our build is very non-deterministic. Instead, it should be:

{CandidateAssemblyFiles};{HintPathFromItem};{TargetFrameworkDirectory};{RawFileName};..\..\..build\bin

The output directory also has no business being there, but we heavily rely on it currently, so we can't fix it easily right now.

VS bug #587463

[slluis]

Where is this set?

[KirillOsenkov]

In two places in Microsoft.Common.CurrentVersions.targets in MSBuild:

http://source.dot.net/#MSBuildFiles/C/ProgramFiles(x86)/MicrosoftVisualStudio/2017/Enterprise/MSBuild/15.0/Bin_/Microsoft.Common.CurrentVersion.targets,563

http://source.dot.net/#MSBuildFiles/C/ProgramFiles(x86)/MicrosoftVisualStudio/2017/Enterprise/MSBuild/15.0/Bin_/Microsoft.Common.CurrentVersion.targets,1148

The SDK targets are already much better: http://source.dot.net/#MSBuildFiles/C/ProgramFiles/dotnet/sdk/2.1.4/Sdks/Microsoft.NET.Sdk/build/Microsoft.NET.Sdk.props,93

[KirillOsenkov]

I can work on this, I can prepare a PR.

[slluis]

So this is not a MonoDevelop bug.

[KirillOsenkov]

Kind of an infrastructure improvement - additional verification that our binaries are resolved from where we think they're resolved from. Let me know if you'd like to track this differently.

[Therzok]

@KirillOsenkov we also need to resolve from addin bin folders. I'm looking at this now, but it seems complicated to fix all in all.