search

mono / monodevelop

MonoDevelop is a cross platform .NET IDE
http://www.monodevelop.com
2.84k stars 1.02k forks source link

Instead of using custom ISerializable to serialize private fields, just expose it via ReadOnlyCollection #9314

Closed manish closed 5 years ago

manish commented 5 years ago

Needs partial reverse of https://github.com/mono/monodevelop/pull/8846

Fixes #1019319

We can just expose the hidden values CounterValue using ReadOnlyCollection with only a getter. It prevents modification of the existing list. This is better since ISerializable has many issues esp Counter.values were not serialized but TimerCounter.values were. Using the additional read-only property provides a C# solution rather than relying on underlying implementation fo Newtonsoft.Json

manish commented 5 years ago

@monojenkins rebase

manish commented 5 years ago

@monojenkins backport release-8.5

manish commented 5 years ago

@monojenkins backport release-8.4

manish commented 5 years ago

@monojenkins backport release-8.5

manish commented 5 years ago

@monojenkins backport release-8.4