[Debugger] Exception caught dialog accessibility

mono / monodevelop

MonoDevelop is a cross platform .NET IDE

http://www.monodevelop.com

2.84k stars 1.02k forks source link

[Debugger] Exception caught dialog accessibility #9398

Closed mrward closed 4 years ago

mrward commented 4 years ago

Fixes VSTS #782188 - Voiceover doesn't give any information about the "eye" and "Pen" icon which are interactive
Fixes VSTS #1025889 - VoiceOver does not announce the image name.
Fixes VSTS #1025898 - ScreenReader focus does not go on the table.

Problems:

Tabbing into and out of the Properties tree view is currently broken. Seems to be a problem with the interaction with the GtkNSViewHost and the native tree view control.

Small changes to the UI:

Replaced the Properties tree view the new native one created by Jeff.
Removed the expanders since they were causing problems with Voice Over.

UI Before:

UI After:

mrward commented 4 years ago

@monojenkins backport release-8.4

sgmunn commented 4 years ago

@mrward I could not get VO to announce the name of the "eye" button. it seemed to just say "button"

mrward commented 4 years ago

Yeah it just says button. With the old tree view it does not recognise the buttons only the text.

sgmunn commented 4 years ago

I thought we named them, or are supposed to name them

mrward commented 4 years ago

Probably. Was only looking at fixing the Voice Over problems specific to the Exception Caught dialog in this pull request.

Fixes in the tree view will fixes problems in that dialog and in the Watch/Locals pad. Not looked at accessibility in the tree view itself.

sgmunn commented 4 years ago

fair enough. fwiw, I think it's just missing AccessibilityTitle (which we have for one of them).

mrward commented 4 years ago

I see the same behaviour in the locals/watch pad as in this pull request. Looking at the code it does not look like accessibility labels have been set for the preview button and eye button, if I am looking in the right place.

sgmunn commented 4 years ago

yes - I was specifically looking because Fixes VSTS #1025889 - VoiceOver does not announce the image name

mrward commented 4 years ago

Will take a look at fixing them here. Not seen any other bugs filed for the Locals/Watch pad.

That image name problem is fixed here. It is the lighting icon at the top of the dialog.

sgmunn commented 4 years ago

or, is that the image that shows what kind of property the object is? I wonder if we should be updating the a11y title to match the property type or ignoring that image altogether?

sgmunn commented 4 years ago

oh, that image

mrward commented 4 years ago

The images and buttons now have an accessibility title.

mrward commented 4 years ago

@monojenkins backport release-8.4