search

mono / monodevelop

MonoDevelop is a cross platform .NET IDE
http://www.monodevelop.com
2.84k stars 1.02k forks source link

[753577][StatusBar] announce changed status #9401

Closed mykyta-bondarenko closed 4 years ago

mykyta-bondarenko commented 4 years ago

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1019006

sevoku commented 4 years ago

This works really nice, not ideal since VO interrupts itself if the status changes quickly, but that's ok, sighted users will also miss the previous status in such a case. First of all this is a huge usability improvement, without this VO users don't get status updates at all right now, so there is no way to know whether an operation has finished.

mykyta-bondarenko commented 4 years ago

@netonjm it's done :)

sevoku commented 4 years ago

@monojenkins rebase

sevoku commented 4 years ago

@mykyta-bondarenko please move AnnounceText method to AtkCocoaHelperMac to a reusable method with something like signature:

public static void MakeAccessibilityAnnouncement (this NSObject o, string message)

and then remove the duplicated code and reuse it in MakeAccessibilityAnnouncement (this Atk.Object o, string message)

We can not do this, AtkCocoaHelperMac is only for AtkCocoa, and we don't have any extensions for native controls, since Xamarin.Mac is not public MonoDevelop.Ide API. I agree that it might be useful to have an extension for this, however that must be done on MonoDevelop.Components.Control level.

@mykyta-bondarenko as discussed on call, let's revert the last change and leave the code in MacPlatform for now.

mykyta-bondarenko commented 4 years ago

@sevoku I've returned the previous version of code back.

sevoku commented 4 years ago

@monojenkins backport release-8.4-a11y