[947006][NewProjectController] added announcement of project creation status

mykyta-bondarenko commented 4 years ago

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/947006

moved MakeAccessibilityAnnouncement to PlatformService.cs
deleted project creation events from GtkNewProjectDialogBackend.cs
added one more announcement after creation process has started

mykyta-bondarenko commented 4 years ago

@Therzok changes are ready

mykyta-bondarenko commented 4 years ago

@mrward thanks, you are right. I saw that it was like this before for a successfully created event, so, I assumed that it's the correct behavior here. But it works properly without it, so, I've deleted these extra invocations.

sevoku commented 4 years ago

@monojenkins backport release-8.4-a11y

monojenkins commented 4 years ago

@sevoku backporting to release-8.4-a11y failed, the patch results in conflicts:

Applying: [947006][PlatformService] moved 'MakeAccessibilityAnnouncement' to `PlatformService `
Using index info to reconstruct a base tree...
M   main/src/addins/MacPlatform/MacPlatform.cs
M   main/src/addins/MacPlatform/MainToolbar/StatusBar.cs
Falling back to patching base and 3-way merge...
Auto-merging main/src/addins/MacPlatform/MainToolbar/StatusBar.cs
CONFLICT (content): Merge conflict in main/src/addins/MacPlatform/MainToolbar/StatusBar.cs
Auto-merging main/src/addins/MacPlatform/MacPlatform.cs
error: Failed to merge in the changes.
Patch failed at 0001 [947006][PlatformService] moved 'MakeAccessibilityAnnouncement' to `PlatformService `

Please backport manually!

sevoku commented 4 years ago

@monojenkins backport release-8.4-a11y

mono / monodevelop

[947006][NewProjectController] added announcement of project creation status #9416