[Debugger] Fixed string quote/unquote logic for VsCode backend

mono / monodevelop

MonoDevelop is a cross platform .NET IDE

http://www.monodevelop.com

2.84k stars 1.02k forks source link

[Debugger] Fixed string quote/unquote logic for VsCode backend #9418

Closed jstedfast closed 4 years ago

jstedfast commented 4 years ago

Also worked around a bug in the VsCode debugger protocol library where it gives us invalid EvaluationName strings that cannot be evaluated (due to casting errors) by using the existing string value.

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1001902 Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1023874

jstedfast commented 4 years ago

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1023874/

sgmunn commented 4 years ago

this has a repro from a user, we should turn that into a test case and link it here

jstedfast commented 4 years ago

Test Case: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1047490

jstedfast commented 4 years ago

ping

jstedfast commented 4 years ago

This has been obsoleted by https://github.com/mono/monodevelop/pull/9513