[Debugger] Move the Download-via-SourceLink prompt into the NoSourceV…

mono / monodevelop

MonoDevelop is a cross platform .NET IDE

http://www.monodevelop.com

2.84k stars 1.02k forks source link

[Debugger] Move the Download-via-SourceLink prompt into the NoSourceV… #9429

Closed jstedfast closed 4 years ago

jstedfast commented 4 years ago

…iew page

Instead of annoying the user with a dialog prompt and then, when the user clicks Cancel, showing them the NoSourceView document - just add a "Download via SourceLink" button to the NoSourceView document tab allowing the user to download the source there.

This simplifies the process and makes it much less annoying.

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/966732/

jstedfast commented 4 years ago

nosami commented 4 years ago

"Step into External Code" is a feature that needs to be enabled manually first so not sure why it would be annoying?

And now, there is no easy to find option to automatically download? I think if you wanted the UI to work this way then there should be a 3rd button to set the "always download" property.

jstedfast commented 4 years ago

@vancura can you review this UI change and make suggestions?

nosami commented 4 years ago

@vancura can you review this UI change and make suggestions?

@hbons probably should take a look too seeing as he was the person involved initially with the design.

sgmunn commented 4 years ago

@vancura the original bug suggested to add an option to automatically do this, which was on the original dialog. should we add that here for completeness?