search

mono / monodevelop

MonoDevelop is a cross platform .NET IDE
http://www.monodevelop.com
2.84k stars 1.02k forks source link

[AspNetCore] Don't create browser-based execution targets for Worker services #9537

Closed rodrmoya closed 4 years ago

rodrmoya commented 4 years ago

With the enabling of launchSettings.json support for Worker services, we added support, by mistake, to run it on the user's installed browsers, which is wrong, as Worker services are just console applications.

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1050466

rodrmoya commented 4 years ago

@monojenkins backport backport-pr-9498-to-release-8.4

monojenkins commented 4 years ago

@rodrmoya backporting to backport-pr-9498-to-release-8.4 failed, the patch results in conflicts:

Applying: [AspNetCore] Don't create browser-based execution targets for Worker services
Using index info to reconstruct a base tree...
M   main/src/addins/MonoDevelop.AspNetCore/MonoDevelop.AspNetCore/AspNetCoreProjectExtension.cs
Falling back to patching base and 3-way merge...
Auto-merging main/src/addins/MonoDevelop.AspNetCore/MonoDevelop.AspNetCore/AspNetCoreProjectExtension.cs
CONFLICT (content): Merge conflict in main/src/addins/MonoDevelop.AspNetCore/MonoDevelop.AspNetCore/AspNetCoreProjectExtension.cs
error: Failed to merge in the changes.
Patch failed at 0001 [AspNetCore] Don't create browser-based execution targets for Worker services

Please backport manually!

rodrmoya commented 4 years ago

This is failing on the known compat check failure only, so ignoring