search

mono / monodevelop

MonoDevelop is a cross platform .NET IDE
http://www.monodevelop.com
2.85k stars 1.02k forks source link

Fixes compatbaseline check for HttpHeaderKind change #9551

Open josegallardo opened 4 years ago

josegallardo commented 4 years ago

This is required for insertion PR https://github.com/xamarin/md-addins/pull/6190

mrward commented 4 years ago

Not sure this is correct. PRs are currently failing since they are building on Mac 10.13 but the master branch is building with Catalina where the compat check is working (was updated by @dalexsoto and this change here seems to revert this change made by Alex - https://github.com/mono/monodevelop/pull/9525/files)

josegallardo commented 4 years ago

Not sure this is correct. PRs are currently failing since they are building on Mac 10.13 but the master branch is building with Catalina where the compat check is working (was updated by @dalexsoto and this change here seems to revert this change made by Alex - https://github.com/mono/monodevelop/pull/9525/files)

Then we shouldn't merge this change and just merge the md-addins PRs even with CompatBaseCheck failing?

Looks like that's the case, and we should just close this PR and merge https://github.com/xamarin/md-addins/pull/6190

Thanks @mrward for the quick catch! @dalexsoto can you please confirm?

josegallardo commented 4 years ago

Adding the do-not-merge label for now until we can confirm this should be closed.

mrward commented 4 years ago

Then we shouldn't merge this change and just merge the md-addins PRs even with CompatBaseCheck failing? Correct. @josegallardo Yeah I would just merge the md-addins change.