search

mono / monodevelop

MonoDevelop is a cross platform .NET IDE
http://www.monodevelop.com
2.85k stars 1.02k forks source link

[1050440]Fix description of Razor files #9580

Closed GouriKumari closed 4 years ago

GouriKumari commented 4 years ago

Fix https://dev.azure.com/DevDiv/DevDiv/_workitems/edit/1050440/

Tasks Done: Change description of Razor view to "Razor View Page"

GouriKumari commented 4 years ago

@nosami : When I tested this the changes didn't reflect. Can you check my changes?

nosami commented 4 years ago

@GouriKumari just test the dmg from the build on this page once it's built

nosami commented 4 years ago

Maybe this isn't the right change

Create a MVC View page. vs Creates an MVC Razor View page.

mrward commented 4 years ago

Yeah the description is not consistent with all the other file templates.

Also I think this is the wrong file template. The bug is about ASP.NET Core projects whilst this file template if for classic ASP.NET projects.

The ASP.NET Core file template that matches Razor View is this one - https://github.com/mono/monodevelop/blob/release-8.5/main/src/addins/MonoDevelop.AspNetCore/Templates/MVCViewPage.xft.xml#L13 - however I cannot see that in the New File dialog - not sure why that is.

mrward commented 4 years ago

Ah, I see. @rodrmoya already changed the name of this file template here - https://github.com/mono/monodevelop/commit/8857b5200ad471c61f0975d1ceeca6eb40ec0eea for another bug.

mrward commented 4 years ago

I think we should just ensure the file template name is consistent with the description for all the file templates changed in this commit - https://github.com/mono/monodevelop/commit/8857b5200ad471c61f0975d1ceeca6eb40ec0eea

Keeping the description so it is similar to 'Creates a Razor View' - replacing the Razor View with the name of the file template.

GouriKumari commented 4 years ago

@mrward : It was my mistake. I was looking at the wrong code base. In Visual Studio For Windows, Razor template description do not have "Creates a" prefix. The change I made here is what we have in Visual Studio For Windows. Update: I changed the description of Razor templates similar to that in Visual Studio For Windows projects. Removed the "Creates" prefix.

mrward commented 4 years ago

I guess my only problem with this is that now the descriptions of the ASP.NET Core file templates are inconsistent with all the other file templates we have.

GouriKumari commented 4 years ago

Reverted the extra changes.