Build issues with VS2010 SP1

mono / ngit

Automated jgit port to c#

261 stars 152 forks source link

Build issues with VS2010 SP1 #40

Closed stinos closed 12 years ago

stinos commented 12 years ago

Sharpen.Extensions.GetTotalInFixed() won't compile due to Cannot implicitly convert type 'long' to 'int'. An explicit conversion exists (are you missing a cast?) Extensions.cs 629, which is easily fixed by changing the function body to

if( inf.TotalIn > 0 )
  return Convert.ToInt32( inf.TotalIn ) + 4;
return 0;

Furrthermore I get 286 warnings, of which most seem to be very easy to fix.

alanmcgovern commented 12 years ago

Could you submit a pull request correcting the issue in GetTotalInFixedSize?

As for the warnings, they are not worth trying to fix. NGit is an automated port from the JGit java source code. Every manual change to the generated files (everything in NGit and NSch) increases the maintenance burden by increasing the likelihood of a conflict when updating to a newer version of JGit. The only changes I make are to fix bugs or make it compile.

stinos commented 12 years ago

goog point about the warnings, I didn't realise completely the port is automatic