search

mono / ngit

Automated jgit port to c#
261 stars 151 forks source link

KeyPair.Generate failure tests #55

Open dougrathbone opened 11 years ago

dougrathbone commented 11 years ago

Hi there,

I've written a test to prove the failure of KeyPair failing with a casting exception.

I'm going to go digging into it, but I'm not sure where the problem exists.

Thoughts?

alanmcgovern commented 11 years ago

I don't want to put arbitrary binaries in the repository as it is a nightmare for us when trying to keep things up to date and building on every platform. Can you write your testcases without requiring a bunch of mono specific assemblies being included in the repository?

dougrathbone commented 10 years ago

With all due respect, I think you should at least accept the pull request into your own repo to see me reproduce the issue. Ignoring me taking the time to raise it for you just because of minutia is a bit saddening. I was trying to actually help.

ArsenShnurkov commented 9 years ago

I support the point of alanmcgovern. @dougrathbone you can add the dependencies as nuget packages or as git submodules

dougrathbone commented 9 years ago

Great to see that neither of you after 2 years wants to even accept that there is a bug. Even though i'd taken the time to jump through hoops to prove it to you. First I raised it, then you challenged me to prove it with a test. Then I did so, and then you complained about the format of my submission because it included dependencies.

The only thing that's quite clear is that you don't want to fix the actual root problem. Which is a real shame as others would hopefully focus on the task at hand - the bug that breaks key generation.

ArsenShnurkov commented 9 years ago

I have no commit right for this repository. What I will do - will fork from some other who enabled issues, and continue from there. https://github.com/Schumix/ngit looks good for my purposes from the first sight

dougrathbone commented 9 years ago

Thank you - the main issue I have is that I can't get the solution to even build without the dependencies i've included. Not sure if you're building on a *nix box or not, but VS wouldn't build the SLN as-is, and nuget's version of some of the mono dependencies are different versions to those reffed.

Let me know if you need help looking into it further or if you want to jump on chat.