search

mono / ngit

Automated jgit port to c#
261 stars 151 forks source link

Sharpen ScheduledThreadPoolExecutor unit tests fail #8

Closed sehe closed 12 years ago

sehe commented 13 years ago

In response to

http://stackoverflow.com/questions/6310691/some-ngit-stuff-prevents-c-application-from-shutting-down-correctly

I thought I'd have a look. I used 4d686e9931116edc3a14 and built with monodevelop 2.6 beta2 (mono 2.11 master/722f989)

ThreeTwo of the ScheduledThreadPoolExecutor unit tests intermittently fail: MonoDevelop NUnit screenshots

The places where it asserts are:

  1. at Sharpen.Test.ScheduledThreadPoolExecutorTests.InsertDelayedTask () [0x000c1] in /tmp/ngit/Sharpen.Test/ScheduledThreadPoolExecutorTests.cs:50
  2. at Sharpen.Test.ScheduledThreadPoolExecutorTests.Shutdown () [0x00077] in /tmp/ngit/Sharpen.Test/ScheduledThreadPoolExecutorTests.cs:98

I'm not too sure whether it's just racey test cases, or that there is a fundamental problem. However, since the asker on Stack Overflow was experiencing shutdown problems with threads waiting around forever, I thought I'd report this just in case.

Cheers, Seth

alanmcgovern commented 12 years ago

These tests are simply racy from what I can tell. The issue with threads hanging around forever was fixed a few weeks ago. The issue we fixed was that we were catching a ThreadAbort exception and resetting it which prevented the appdomain from being shut down, and thus preventing the application from exiting.