search

mono / sdb

A command line client for the Mono soft debugger.
https://www.mono-project.com
MIT License
117 stars 44 forks source link

Attach running process #59

Closed akihikodaki closed 5 years ago

akihikodaki commented 5 years ago

Closes #6.

akihikodaki commented 5 years ago

I was not aware of connect command.

Well, maybe those who have used gdb before will look for attach command and may have misconception that the feature is not implemented. That is exactly my case. I think this command should be implemented as an alias or removed. Which do you prefer, or do you have another idea?

thaystg commented 5 years ago

I think that attach should be implemented to be used with PID as gdb. But to avoid this misconception, we can put a message like: "Attempts to attach to the given process ID.\n" + "\n" + "Currently unimplemented.\nUse connect command." What do you think?

alexrp commented 5 years ago

I think that attach should be implemented to be used with PID as gdb.

This was the original intention, but I never got around to implementing it this way because (at least at the time) that seemed fairly non-trivial and would probably have involved using Mono's general-purpose assembly attach mechanism: https://github.com/mono/mono/blob/master/mono/metadata/attach.c

It's quite possible the VSfM team figured out a better solution in the meantime though. I'm not up to date on the issue.

I have no objection to updating attach's help text to point to the connect command until it's actually implemented.

akihikodaki commented 5 years ago

Anyway, this change for attach command is no longer relevant. I'll close this pull request.